spring-cloud / spring-cloud/spring-cloud-gateway

Support CF Route Services

Open
#190 7 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
4.9k
Forks
3.5k
Avg merge
20h 57m
Merged PRs (30d)
8

Description

I started writing this up as a post on the spring-cloud Gitter, but thought it might make more sense to post somewhere a little more permanent.
I recently wrote a blog post about using spring cloud gateway to create a route service. First off/selfishly, I was wondering if anyone had suggestions on alternate approaches I could/should have taken to implement the route service.

Secondly, I wanted to bring up a couple ergonomic issues and see if they would make sense to create separate issues/contributions for:

  • Should it be possible to create a route without a URI? This might make sense if the final destination is determined within a filter
  • Does a single arg header filter make sense? This would just check for the existence of a header... instead of header("X-My-Header", ".*"), it would be header("X-My-Header")
  • in GatewayFilterSpec:
    • Should add and filter both exist? It feels a little weird that they both exist w/ the same functionality
    • If add and filter are meant to be aliases, should it be possible to specify an order using add?
    • Should there be a varargs version of addAll? Adding multiple filters is currently a little awkward
    • Would it make sense to automatically get the order for filters which implement Ordered?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing GatewayFilterSpec and the route-creation behavior described in the issue, then compare the proposed route-service use case with the linked blog post. The scope is not yet settled: completion would require a decision on URI-less routes and the filter API questions before implementation can be defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring, spring-boot
Domain
api, backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.