spring-cloud / spring-cloud/spring-cloud-gateway
Validate route uri
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.9k
- Forks
- 3.5k
- Avg merge
- 20h 57m
- Merged PRs (30d)
- 8
Description
Writeup and example: https://github.com/RyanBard/scg-npe
spring-cloud-gateway version: 2.0.0.M5
spring-boot-version: 2.0.0.M7
I'm getting a NullPointerException in NettyRoutingFilter on line 67 because scheme is null. It's possible that my configuration in my application.yml is bogus (the uri and predicate Path do not match -- EDIT: I've verified that it still fails for the same reason even if they do overlap), however, it looks like the overwriting of scheme in the UriComponentsBuilder calls in RouteToRequestUrlFilter could be problematic in other situations.
I would appreciate if you could take a look.
Thank you
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the linked scg-npe example and inspect NettyRoutingFilter line 67 alongside RouteToRequestUrlFilter. Compare the application.yml URI and Path cases described in the report. Done means the route URI problem is handled without the reported NullPointerException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100