spring-cloud / spring-cloud/spring-cloud-consul
Incorrect health check path registered with spring-boot-actuator 1.3
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 822
- Forks
- 539
- Avg merge
- 9h 31m
- Merged PRs (30d)
- 7
Description
When using spring-boot-actuator 1.3, the health endpoint is now nested under server.contextPath when management.port is set. Note that this is different behavior than with spring-boot-actuator 1.2.5, and potentially breaking. Regardless of the spring-boot-actuator version, spring-cloud-consul does not seem to consider the contextPath of the management endpoints. Considering the appropriate contextPath in ConsulLifecycle.createCheck could be helpful and reduce the need for configuration via properties.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ConsulLifecycle.createCheck and compare the registered health-check path with Spring Boot Actuator 1.3 behavior when management.port and server.contextPath are set. Verify that the Consul check accounts for the management endpoint context path and that the behavior remains appropriate for Actuator 1.2.5.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100