spring-cloud / spring-cloud/spring-cloud-consul
getAllInstances in ConsulDiscoveryClient does not use ACL token for requests
Open
Nobody has claimed this yet.
waiting-for-triage
- Dominant language
- Java
- Stars
- 822
- Forks
- 539
- Avg merge
- 9h 31m
- Merged PRs (30d)
- 7
Description
The method ConsulDiscoveryClient.getAllInstances() does not use the ACL token for requests. This means that requests to a Consul instance that requires authentication will fail and the method will return an empty list.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ConsulDiscoveryClient.getAllInstances() and inspect how its Consul requests are built and authenticated. Reproduce the behavior against a Consul instance requiring an ACL token, then verify that authenticated requests return the expected instances instead of an empty list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100