spring-cloud / spring-cloud/spring-cloud-consul

Add support for spring cloud loadbalancer and datacenter

Open
#712 0 comments 0 reactions 0 assignees View on GitHub

@d4c4nf3 is already working on this.

Since Nov 7, 2020.

  • #681 by @d4c4nf3 — open
enhancement
Dominant language
Java
Stars
822
Forks
539
Avg merge
9h 31m
Merged PRs (30d)
7

Description

The spring.cloud.consul.discovery.datacenters field is no longer read anywhere. 7a21240a82515f284f46fc2040d6731746e8ad9e introduced support in ribbon but that has been lost in translation to spring cloud loadbalancer. Also see #444 and #681

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing commit 7a21240a82515f284f46fc2040d6731746e8ad9e and the discussion in issues #444 and #681 to understand the earlier Ribbon behavior. Compare that with the current Spring Cloud LoadBalancer path and verify that spring.cloud.consul.discovery.datacenters is honored; issue #681 is already linked to this work.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.