spring-cloud / spring-cloud/spring-cloud-consul
@AutoConfigurationOrder doesn't seem to have any effect on the bootstrapping order anymore.
@spencergibb is already working on this.
Since May 13, 2019.
- Dominant language
- Java
- Stars
- 822
- Forks
- 539
- Avg merge
- 9h 31m
- Merged PRs (30d)
- 7
Description
Question:
Upgrading from spring-boot 2.0.3 to 2.1.3 and spring-cloud Finchly.RELEASE to Greenwhich.RELEASE the work around in gist https://gist.github.com/mp911de/17f550ffecdc9e8f22061bfdf896bbb4 doesn't seem to be working anymore. Debugging it appears that the code is called but the "@AutoConfigureOrder(1)" no longer is placing the setting of "spring.cloud.consul.token" before the ConsulDiscoveryProperties are configured so the embedded aclToken is set to null instead the value extracted from Vault.
Changing the @AutoConfigurationOrder doesn't seem to have any effect on the bootstrapping order anymore. Open to suggestions on what else changed between these releases that could have broken the posted work around. We are trying to upgrade the framework to test other spring-cloud bug fixes but are blocked on getting the bootstrapping ordering correct.
https://github.com/spring-cloud/spring-cloud-vault/issues/58#issuecomment-479255720
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.