spring-cloud / spring-cloud/spring-cloud-consul

Make spring boot starter web optional.

Open
#262 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
822
Forks
539
Avg merge
9h 31m
Merged PRs (30d)
7

Description

spring-cloud-consul-discovery version 1.1.2.RELEASE says that joda-time is an optional dependency, but it appears as though it is needed by the org.springframework.cloud.consul.discovery.HeartbeatProperties class. It doesn't seem possible for a consumer to just have a compile time dependency on spring-cloud-consul-discovery without also explicitly including a runtime dependency on joda-time. Is this expected or am I not understanding how to correctly use this dependency? I'd rather not use the starter dependencies as it includes a lot of other stuff I don't want.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the spring-cloud-consul-discovery 1.1.2.RELEASE dependency metadata and the org.springframework.cloud.consul.discovery.HeartbeatProperties class first. Verify which dependencies are required at compile and runtime, then confirm that the declared optional dependencies match actual consumer requirements without pulling in unwanted starter components.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.