spring-cloud / spring-cloud/spring-cloud-consul
Enabling SSL on service doesn't change the reported health check URL
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 822
- Forks
- 539
- Avg merge
- 9h 31m
- Merged PRs (30d)
- 7
Description
Although I've enabled SSL on my spring-boot application by setting the server.ssl.key-store related properties Spring-Cloud-Consul still registers my service using a regular http address instead of https.
I know I can manually override this by setting the spring.cloud.consul.discovery.health-check-url but in that case I need to find out a way to specify the host-name (or ip-address) which is done automatically when spring-cloud-consul is constructing the url.
Can't spring-cloud-consul detect the fact that I'm running on SSL?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the server.ssl.key-store properties enabled and inspect how Spring-Cloud-Consul constructs the registered health-check URL. Done means an SSL-enabled application is registered with an https health-check URL while the host name or IP address continues to be determined automatically.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100