spring-cloud / spring-cloud/spring-cloud-config
Handle Git connection issues when fetching data
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 1.3k
- Avg merge
- 2d 59m
- Merged PRs (30d)
- 16
Description
When JGitEnvironmentRepository fetching data (see fetch method)
and Git is unavailable at this moment (for example we got UnknownHostException), we just log WARN message and return null FetchResult.
I propose to send some ApplicationEvent in this case for adding the possibility to handle this situation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the fetch method in spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/JGitEnvironmentRepository.java, especially its handling of Git unavailability such as UnknownHostException. Determine the ApplicationEvent trigger and payload, then verify that the event is emitted for this failure instead of only logging a warning and returning a null FetchResult.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, java, spring
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100