spring-cloud / spring-cloud/spring-cloud-config
Add ability to configure Vault client TLS enabled protocol versions and cipher suites via Spring properties
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 1.3k
- Avg merge
- 2d 59m
- Merged PRs (30d)
- 16
Description
In https://github.com/spring-projects/spring-vault/issues/635 support was added for configuring the enabled client TLS protocols and cipher suites to be configured via Spring application properties. It would be great if we could also configure these via Spring application properties for the Spring Cloud Vault client.
The org.springframework.vault.config.EnvironmentVaultConfiguration.sslConfiguration() was updated to set protocol and cipher suites on the org.springframework.vault.support.SslConfiguration instance returned. The org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration.sslConfiguration() method could be updated to do the same.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration.sslConfiguration() alongside org.springframework.vault.config.EnvironmentVaultConfiguration.sslConfiguration(), which already sets the protocol and cipher-suite values. Update the Spring Cloud Vault client configuration so Spring application properties can configure both values, then verify that the returned SslConfiguration contains them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend, cloud
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100