spring-cloud / spring-cloud/spring-cloud-config
Use 'spring.cloud.config.server.default-profile' property for GIT and Vault backend as a default
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 1.3k
- Avg merge
- 2d 59m
- Merged PRs (30d)
- 16
Description
Is your feature request related to a problem? Please describe.
We want to use spring cloud config server as a part of our application with Git and Vault backends. Our idea is to configure the default profile and label on config server level and allow clients to skip this parameters in the request. It is possible to set spring.cloud.config.server.git.default-label in config server which will be used if there will be no label in the client request. Also, there is a property spring.cloud.config.server.default-profile with javadoc "Default application profile when incoming requests do not have a specific one." that I expect will do a similar thing for profile. But this property ignored when a client tries to request configuration from config server without a profile in a request.
Describe the solution you'd like
Use spring.cloud.config.server.default-profile property value for GIT and Vault backend as a default profile if there is no profile (spring.cloud.config.profile) property in a client request.
Describe alternatives you've considered
Send profile(spring.cloud.config.profile) as a part of the client request
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how spring.cloud.config.server.default-profile is handled for the Git and Vault backends when a client omits spring.cloud.config.profile. Compare that behavior with the existing default-label behavior, then verify that requests without a profile use the configured default for both backends.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, java, spring, spring-boot
- Domain
- api, backend, cloud
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100