spring-cloud / spring-cloud/spring-cloud-config

Log a message when fetch is done, even if there are no updates?

Open
#1,495 7 comments 0 reactions 1 assignee View on GitHub

@Anbazhagan04 is already working on this.

Since Mar 7, 2022.

enhancement help wanted
Dominant language
Java
Stars
2k
Forks
1.3k
Avg merge
2d 59m
Merged PRs (30d)
16

Description

JGitEnvironmentRepository logs a message starting with "Fetched for remote" in its fetch method, but only when the fetch results reports there were updates.

Could you update to always log it, even if result.getTrackingRefUpdates().size() == 0?

Or, is there some other way I can tell by the logs (at level "info") when it has done a fetch? I don't see anything else being logged that would indicate this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.