spring-cloud / spring-cloud/spring-cloud-config
ConfigClientWatcher with Git backend
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 1.3k
- Avg merge
- 2d 59m
- Merged PRs (30d)
- 16
Description
With git backend, as I know, Environment.getVersion() return HEAD Commit's checksum.
But ConfigClientWatcher just watch "config.client.state" value.
If ConfigClientWatcher watch "config.client.version", It would be works well with git without any config. And it might need ConfigClientVersionHolder also.
How do you think about this? I would like to make an implementation based on this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing ConfigClientWatcher and how it currently observes "config.client.state" with the Git backend. Check the role of ConfigClientVersionHolder, then determine the tests or configuration paths that should verify watching "config.client.version" and confirm the proposed behavior works without extra configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, java, spring
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100