spring-cloud / spring-cloud/spring-cloud-commons

Can i stop clean up when refresh

Open
#639 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

waiting for votes
Dominant language
Java
Stars
751
Forks
744
Avg merge
1d 14h
Merged PRs (30d)
9

Description

https://github.com/spring-cloud/spring-cloud-commons/blob/18a4227c4ef1bdf86c3103e64bce75847a53073e/spring-cloud-context/src/main/java/org/springframework/cloud/bootstrap/config/PropertySourceBootstrapConfiguration.java#L135

I have used my custom log appenders ,when my context refreshed ,my appenders has been lost. So i wonder if i can stop using this function through properties config.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with spring-cloud-context/src/main/java/org/springframework/cloud/bootstrap/config/PropertySourceBootstrapConfiguration.java at line 135, then trace the cleanup triggered by a context refresh. Reproduce the loss of a custom log appender and determine where a property-based opt-out would apply. Done means the cleanup can be disabled through configuration and the behavior is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.