spring-cloud / spring-cloud/spring-cloud-commons
Streamline ordering of PropertySources
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 751
- Forks
- 744
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
Currently the implementations of externalized configuration (git, native, jdbc, vault, consul, kubernetes,...) have a different mechanism to order the PropertySources. This issue is to streamline this process in spring-cloud-context so all implementations are returning the properties in the same order.
Current take would be opt-in for Greenwich and opt-out for Hoxton to have little impact as possible since this is a breaking change.
Also see: https://github.com/spring-cloud/spring-cloud-commons/issues/165, https://github.com/spring-cloud/spring-cloud-config/issues/1434, https://github.com/spring-cloud/spring-cloud-config/pull/1437
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the spring-cloud-context ordering code and the referenced issues and pull request, then compare how the git, native, JDBC, Vault, Consul, and Kubernetes implementations order PropertySources. Done means these implementations use the same ordering mechanism, with the proposed Greenwich opt-in and Hoxton opt-out compatibility behavior addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, cloud
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100