spring-cloud / spring-cloud/spring-cloud-commons
SimpleDiscoveryClient does not publish an InstanceRegisteredEvent?
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 751
- Forks
- 744
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
We are developing a collection of services to deploy into an Openshift environment. One of the applications is a simple Spring Cloud Gateway instance.
When developing a service locally (e.g. serviceA) we would like to also test the gateway to access serviceA. We are using the SimpleDiscoveryClient in the Gateway to configure the location of serviceA. We noticed that the SimpleDiscoveryClientAutoConfiguration does not publish a InstanceRegisteredEvent, which means that the DiscoveryClientHealthIndicator is never initialized. Is this intentional?
Our Gateway pom depends on spring-cloud-dependencies Finchley.SR1, which depends on spring-cloud-commons 2.0.1.RELEASE.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading SimpleDiscoveryClientAutoConfiguration and the initialization path for DiscoveryClientHealthIndicator. Check whether an InstanceRegisteredEvent is expected for the SimpleDiscoveryClient, then verify the behavior with the existing project tests; done means the intended event and health-indicator behavior is established and covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, cloud
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100