spring-cloud / spring-cloud/spring-cloud-commons

Guard the bootstrap of CompositeDiscoveryClientAutoConfiguration with property

Open
#1,600 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

waiting-for-triage
Dominant language
Java
Stars
751
Forks
744
Avg merge
1d 14h
Merged PRs (30d)
9

Description

Currently, whether you like it or not, the CompositeDiscoveryClientAutoConfiguration will create the CompositeDiscoveryClient, which in general is fine, but sometimes it is not. In our case, for instance, we want to use our own DiscoveryClient directly, we cannot really use the CompositeDiscoveryClient for various reasons.

So, that would be nice if there would be at least some ways to configure this behavior. For instance, to preserve backward behavioral compatibility by default CompositeDiscoveryClient is created, but some property would allow to omit the creation of CompositeDiscoveryClient bean.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at CompositeDiscoveryClientAutoConfiguration and read how its bean is currently created and conditioned. Add a configurable opt-out while preserving the current default behavior, then verify that the property prevents the CompositeDiscoveryClient bean from being created.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.