spring-cloud / spring-cloud/spring-cloud-commons
spring.cloud.refresh.never-refreshable not ignoring class
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 751
- Forks
- 744
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
Describe the bug
Hi folks,
I have a class name set in spring.cloud.refresh.never-refreshable to be ignored for refresh.
This however doesn't work because Spring adds some EnhancerBySpringCGLIB to the class name.
Thus, this snippet org.springframework.cloud.context.properties.ConfigurationPropertiesRebinder#getNeverRefreshable fails when calling getClass().getName()
Sample
1.) set prop: spring.cloud.refresh.never-refreshable=com.sth.IgnoreMe
2.) bean.getClass().getName() - returns during runtime a modified com.sth.IgnoreMe$$EnhancerBySpringCGLIB$$aaffeeaa and the comparison against the prop value of com.sth.IgnoreMe fails.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at org.springframework.cloud.context.properties.ConfigurationPropertiesRebinder#getNeverRefreshable and reproduce the behavior with spring.cloud.refresh.never-refreshable set to com.sth.IgnoreMe. The issue is resolved when the configured class remains ignored even when its runtime name includes the Spring-generated EnhancerBySpringCGLIB suffix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100