spring-cloud / spring-cloud/spring-cloud-commons

Custom metric's tag for MicrometerStatsLoadBalancerLifecycle

Open
#1,258 1 comment 0 reactions 1 assignee View on GitHub

@OlgaMaciaszek is already working on this.

Since Nov 21, 2024.

enhancement
Dominant language
Java
Stars
751
Forks
744
Avg merge
1d 14h
Merged PRs (30d)
9

Description

Is your feature request related to a problem? Please describe.
I'm integrating Spring Cloud LoadBalancer with a Consul Discovery Client and I want to include own Consul's instance tags in metrics from Load Balancer.

Describe the solution you'd like
I'd like to register custom customizer bean, which could enrich micrometer's tags for load balancer metrics.

Describe alternatives you've considered
I've Implemented own LoadBalancerLifecycle to gather metrics only to add few tags, but it seems tedious, especially having mechanism in a MicrometerStatsLoadBalancerLifecycle class.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.