spring-cloud / spring-cloud/spring-cloud-commons
SSLContextFactory should allow for no key store
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 751
- Forks
- 744
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
I am using 3.1.4. My spring cloud config server has a self signed cert. I did not want to add its certificate to java trust store, so I wanted to use TlsProperties to provide the trust store. I can't do that without providing the keystore.
Currently the trust store is optional, I think the keystore needs to be optional too, as not always we need to use ssl client verification.
I can made a PR with the change, but I am not sure if removing this requirement in a straightforward way is OK for you.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating SSLContextFactory and TlsProperties in the Spring Cloud Commons source, then trace how the keystore requirement is enforced when configuring TLS. Verify the change with the existing SSL or TLS tests, ensuring a trust store can be supplied without requiring a keystore while preserving client verification behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100