spring-cloud / spring-cloud/spring-cloud-build

incorrect formatting for a record + @DefaultValue

Open
#236 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

waiting-for-triage
Dominant language
Shell
Stars
225
Forks
295
Avg merge
18h 57m
Merged PRs (30d)
14

Description

If I have a very simple record in the form:

public record TestRecord(@DefaultValue({"123", "456" }) Set<Integer> knownSecurePorts){
}

this in spring-cloud-kubernetes that uses 4.0.0-SNAPSHOT. and run mvn compile for it, it is formatted like this:

public record TestRecord(@DefaultValue( {
		"123", "456" }) Set<Integer> knownSecurePorts){
}

So the next time I try to issue mvn compile, it will fail.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the record formatting in spring-cloud-kubernetes by running mvn compile with the shown @DefaultValue annotation, then trace the shared build and formatting configuration in spring-cloud-build. Done means the annotation is formatted consistently and a subsequent mvn compile does not produce another source change.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.