spotify / spotify/SPTPersistentCache
Deployment target triggers a compiler warning in Xcode 12+
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 1.2k
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
Xcode 12 dropped support for iOS 8:
https://developer.apple.com/documentation/xcode-release-notes/xcode-12-release-notes
When compiling the project in Xcode for the simulator I get the following warning:
The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.
I can see that from the xcconfig file that deployment target is explicitly set to 8.0:
https://github.com/spotify/SPTPersistentCache/blob/master/ci/spotify_os.xcconfig#L21
I've increased to 12.0 locally for my project and it all builds ok. However I do not want to deviate the fork from the Spotify repo.
Would it be possible to bump to 9.0 at least please?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open ci/spotify_os.xcconfig and inspect the deployment target setting identified at line 21. Build the project for the simulator with Xcode 12 or later to confirm the warning, then verify that the target is at least 9.0 and the warning is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- build-system, mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100