spockframework / spockframework/spock

Interaction check takes precedence over exceptions

Open
#496 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Module-Core Type-Defect
Dominant language
Java
Stars
3.6k
Forks
483
PR merge metrics
No merged PRs in 30d

Description

Originally reported on Google Code with ID 374

Having a test like this

def "Should Create"() {
    when: "We do stuff"
    this.someStuff.do()

    then: "Should not get exception"
    noExceptionThrown()

    and: "Should send mail"
    1 * mailSession.send(*_)
}

If someStuff.do() throws an exception, "Too few invocations for send" is reported instead
of "Exception thrown".

I'd expect the exception to be reported first since the send is not invoked only due
to the exception (as the program never gets to send the mail due to the exception).

Reported by ziacik on 2014-09-17 09:42:43

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation file or test path is named. Start by reproducing the shown specification with an exception and an unmet interaction, then trace the failure-reporting entry point. Done means the exception is reported before the interaction failure when the interaction was skipped because of that exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy, java
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.