spockframework / spockframework/spock

Initialization in setupSpec for a @Shared field defined in trait is overridden

Open
#492 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Module-Core Type-Defect
Dominant language
Java
Stars
3.6k
Forks
483
PR merge metrics
No merged PRs in 30d

Description

Originally reported on Google Code with ID 370

I've been playing with Spock and traits mix and I spotted an issue with @Shared field
declared in a trait. Following code fails:

class SharedTraitUsage extends Specification implements MySharedTrait {
def "should not restore inline assigned value on shared field defined in trait before
every test"() {
expect:
sharedValue == 11
}
}

trait MySharedTrait {
@Shared
int sharedValue = 12

def setupSpec() {
sharedValue = 11
}


with the error:

Condition not satisfied:

sharedValue == 11
| |
12 false


I started debugging AST transformations using `EmbeddedSpecification`, but I wasn't
able to find a clear way how to "fix" it. More details and a broken test I will put
as a pull request.

Reported by mszpak@wp.pl on 2014-07-14 21:32:29

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with EmbeddedSpecification and the AST transformations involved in trait handling. Reproduce the SharedTraitUsage example with a regression test based on the reported setupSpec behavior. Done means the setupSpec assignment to sharedValue remains 11 instead of being restored to its inline value of 12.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.