possible bug in grails using spock+controller handleException method

Originally reported on Google Code with ID 345

hi, 

I'm using grails 2.3.5 and spock.
i got a particular configuration, and i'm facing some strange behavior with spock tests.

in order to replicate the problem you can find a semplification on my project here:


https://github.com/tamershahin/spockTest.git

this is the situation: 
class TestController { 

 def index() { 
        ... 
        throw new Exception('dummy') 
  } 

 def indexObj(IndexCommand command) { 
       ... 
        throw new Exception('dummy') 
    } 

   def handleException(Exception e) { 
        if (Environment.current == Environment.DEVELOPMENT) { 
            log.debug 'Exception:: ', e 
        } 
    } 
} 
essentially, if i run a test with this code: 

    void "test with "() { 

        when: 'pass to the action a mocked commandObject' 
        def commandMock = mockCommandObject(IndexCommand) 
        commandMock.id = 1 
        controller.indexObj(commandMock) 

        then: "expected a Exception" 
        Exception ex = thrown() 
        assert ex 

    } 

test pass without any problem (wrong, the exception is not propagated to handleException)


if i run a test with this code: 

   void "test without "() { 

        when: 'call the action' 
        controller.index() 

        then: "expected a Exception" 
        Exception ex = thrown() 
        assert ex 

    } 

test will fail with this message: Expected exception java.lang.Exception, but no exception
was thrown. this should be the correct behavior. 

bref, if an action use commandObject the handleException is not executed. 
this only in spock testes. in normal application run everything is fine. 

Reported by tamer.shahin on 2014-02-03 09:31:11

Start with the linked spockTest.git reproduction and compare the two controller Spock tests: one calls indexObj with a mocked IndexCommand, while the other calls index directly. Reproduce the differing exception behavior and inspect how the controller's handleException method is reached; done means the command-object case behaves consistently with the direct action case.