spockframework / spockframework/spock

Reflection Assert / Lenient Assertions

Open
#409 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Module-Core Type-NewFeature
Dominant language
Java
Stars
3.6k
Forks
483
PR merge metrics
No merged PRs in 30d

Description

Originally reported on Google Code with ID 287

Describe the new feature you have in mind.

Provide a good syntax that works like Unitils ReflectionAssert.assertReflectionEquals

e.g. 

expect:
x refeq y
x === y
y ~~ y

Which particular problem would this feature solve for you?

Would make Spock even more convenient :) Objects often have equality implementations,
but tests often want to check for "full" equality (all properties are equal)

Please provide any additional information below. You can also assign
labels.

When adding this feature it would be cool if lenient assertions could be added too.
Here is an example: 

["a", "b"] equalsIgnoringOrder ["b", "a"]
[x, y] reflectionEqualsIgnoringOrder [y, x]

AND this would be a very helpful lenient assertion too: 

a ~ [ id: 1, name: "x" ]
where the assertion succeeds if a has the properties id, name with the given values.

Reported by peter.rietzler@smarter-ecommerce.com on 2012-12-10 14:02:20

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by reviewing Spock's existing assertion APIs and the referenced Unitils ReflectionAssert behavior. Done requires a decided syntax and semantics for reflection equality, order-insensitive comparisons, and lenient property matching, with corresponding tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy, java
Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.