spockframework / spockframework/spock
getMessage() of ConditionNotSatisfiedError/SpockComparisonFailure should not include power assert output
Open
Nobody has claimed this yet.
Module-Core
Type-Enhancement
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 483
- PR merge metrics
- No merged PRs in 30d
Description
Originally reported on Google Code with ID 123
In JUnit reports, getMessage() of the thrown exception is shown in a heading, and toString()
in an unformatted block. Therefore, the message should only contain "Condition not
satisfied: <source text>", but not the actual values.
Reported by pniederw on 2010-08-31 11:42:31
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing getMessage() on ConditionNotSatisfiedError and SpockComparisonFailure, then compare how JUnit reports use getMessage() and toString(). The finished behavior should keep only "Condition not satisfied: " in getMessage(), with power assert values excluded while remaining available through toString().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100