spockframework / spockframework/spock
thrown() assertion failures include spock code in stracktrace
Open
Nobody has claimed this yet.
Module-Core
Type-Enhancement
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 483
- PR merge metrics
- No merged PRs in 30d
Description
Originally reported on Google Code with ID 72
junit.framework.AssertionFailedError: Expected exception java.lang.IllegalStateException,
but no
exception was thrown
at spock.lang.Specification.thrown(Specification.java:218)
Would be better for the user if that stack frame was filtered out.
Reported by ldaley on 2010-02-24 04:45:27
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at spock.lang.Specification.java:218, the stack-trace frame shown in the reported failure. Trace how thrown() reports an expected exception that was not thrown and identify the existing stack-trace handling around that path. Done means the user-facing failure no longer includes the Spock assertion frame while still reporting the assertion failure correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100