spockframework / spockframework/spock
Duplicates occurring when generating unrolled test names should cause test failures
Open
Nobody has claimed this yet.
- #1099 by @pbielicki — closed without merging
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 483
- PR merge metrics
- No merged PRs in 30d
Description
Similarly to #767, test cases whose names are not unique (after unroll kicks in) should fail.
Having multiple tests with exactly the same name may cause the following problems:
- It's difficult to identify exact parameters that cause a test to fail
- In case some tests, with the same name, are passing and some failing different tools (e.g. Gradle Enterprise) might mark such tests as FLAKY, whereas they are most probably legitimate failures:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the related issue #767 and the closed pull request #1099 first, then trace how unrolled test names are generated. Confirm how duplicate names are currently handled and add coverage showing that duplicates cause failures; done means non-unique names no longer pass silently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100