Make sure sorted and unsorted OTLP to STEF converters are consistent for PointValueTypeNone
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 11
- Forks
- 6
- Avg merge
- 55m
- Merged PRs (30d)
- 1
Description
The sorted converter skips empty value type data points entirely (lines 121-122), while the unsorted converter processes them and maps them to PointValueTypeNone (baseotlptostef.go:46-47). This creates a behavior discrepancy between the two conversion paths where unsorted writes all data points but sorted skips empty ones. For consistency, consider either: 1) Having both paths skip empty value types, or 2) Having both paths convert them to PointValueTypeNone. The current implementation may cause confusion where the same input produces different output counts depending on which converter is used.
Originally posted by @Copilot in #371
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the sorted converter behavior at lines 121-122 with the unsorted handling in baseotlptostef.go at lines 46-47. Decide, with maintainer guidance, whether empty value types should be skipped or mapped to PointValueTypeNone, then add coverage showing both conversion paths produce consistent output counts and values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100