Re-enable and refactor code that validates the specific counts of each risk event matched to each observable
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 139
- Forks
- 52
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
- The original version of this feature tried to validate that there was en equal amount of matched risk events for each relevant observable
- This logic was faulty, as some observables may have more corresponding risk events than others (could be due to sparse field values, or because a certain field might be a list of values, and we would get a risk event for each element of that list)
- To re-enable this code, we would need to count the number of values in the corresponding field of each event returned by the search query (e.g. if we have multiple values in the target field of one of the returned events, we would expect one risk event for each value in that field)
- See 'Excessive Usage Of Cacls App' for an example of this (we'd expect more occurences of the process_name observable than the dest observable)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the original or disabled logic that validates matched risk-event counts, then inspect the search-query results and the corresponding observable fields. Use “Excessive Usage Of Cacls App” as the example, and consider the work done when validation counts field values per event and permits different totals for different observables.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100