The "User Name" type should map to a "user" risk object and not "other"
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 139
- Forks
- 52
- Avg merge
- 1h 16m
- Merged PRs (30d)
- 3
Description
- In
detection_abstract.pywe look for observable of typeusername - In practice, the valid type (see
SES_OBSERVABLE_TYPE_MAPPING) isUser Name;Username/usernameis invalid and static validation does not allwo for these values - This is causing a handful of detections to create risk objects of type
otherinstead of typeuser - Additionally,
deviceis not a valid observable type perSES_OBSERVABLE_TYPE_MAPPING(used in validation)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review detection_abstract.py alongside SES_OBSERVABLE_TYPE_MAPPING and the static validation that uses it; confirm the accepted observable names for User Name and device. Verify that detections using User Name produce a user risk object rather than other, and that device handling agrees with the valid observable types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100