splunk / splunk/addonfactory-github-workflows

COC and CLA jobs overrides each other

Open
#59 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Description

The issue

The first job asks about CLA, then another job, COC, runs and overrides the comment from the first one. The end user sees the latest message about COC and has no idea of that CLA also has to be signed.

It seems like a bug (or feature) of contributor-assistant/github-action:
https://github.com/contributor-assistant/github-action/blob/master/src/pullrequest/pullRequestComment.ts#L58
It looks for the first occurance of comment with CLA Assistant Lite bot and edits that comment. This github action is not supposed to work as jobs simultaneously.

Solutions

Possible solution 1: merge CLA and COC into a single job.
Possible solution 2: find another alternative for contributor-assistant/github-action

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the reusable workflow definitions in this repository and contributor-assistant/github-action's src/pullrequest/pullRequestComment.ts around line 58. Reproduce the CLA and COC jobs running together, then determine which workflow-level or action-level approach preserves both messages. Done means the two checks no longer overwrite each other's user-facing comments.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.