spinframework / spinframework/spin

Upgrade to `opentelemetry_sdk` 0.32.1 to address vulnerability

Open
#3,598 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
6.5k
Forks
310
Avg merge
1d 20h
Merged PRs (30d)
24

Description

https://github.com/spinframework/spin/pull/3595 required updating spin-timer's Cargo.lock file, which bumped opentelemetry_sdk's version, which caused the "Review new dependencies for known vulnerabilities" CI check to fail due to https://github.com/advisories/GHSA-w9wp-h8wv-79jx.

That's technically a false positive since both the old and new versions of that dep are vulnerable, and the version bump was done in the top level Cargo.toml a month ago. In any case it needs to be addressed, but since it's unrelated to the PR, I'm going to disable the check temporarily with a comment to re-enable it once this issue has been addressed.

FWIW, I took a stab at addressing it myself, but it turned into a rabbit hole, so I had to punt.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the top-level Cargo.toml and the spin-timer Cargo.lock changes described in the issue, then inspect the "Review new dependencies for known vulnerabilities" CI check and advisory GHSA-w9wp-h8wv-79jx. Determine how to update opentelemetry_sdk to 0.32.1 without leaving the check falsely failing, and re-enable the temporarily disabled check once it passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.