spinframework / spinframework/spin
Consider merging `spin-locked-app` into `spin-app`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 6.5k
- Forks
- 310
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 24
Description
These were originally separated because spin-app depended on spin-core / wasmtime and spin-locked-app had some dependents that didn't otherwise need wasmtime.
With https://github.com/spinframework/spin/pull/2753 this is no longer the case and it would probably be a nice simplification to merge these two crates, with spin_locked_app becoming e.g. spin_app::locked.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the spin-app and spin-locked-app crates and reviewing PR #2753, including their spin-core and wasmtime dependencies. Trace the dependents that use each crate and determine the appropriate spin_app::locked boundary. Done means the crates are merged without unnecessary wasmtime dependency concerns and all affected dependents continue to build and test successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100