spinframework / spinframework/spin

PR and release workflow improvements umbrella issue

Open
#2,371 5 comments 0 reactions 1 assignee View on GitHub

@rajatjindal is already working on this.

Since Mar 18, 2024.

ci
Dominant language
Rust
Stars
6.5k
Forks
310
Avg merge
1d 20h
Merged PRs (30d)
24

Description

We have been running into some problems with PR and Release workflows. We especially felt the pain during debugging of ssl issue during mqtt work.

I am trying to find out all the differences between build and release workflows to make them consistent for easy debugging and predictable behavior:

  • PR workflows don't build for Linux/Mac aarch64 targets
  • Toolchain setup is done using .github/actions/spin-ci-dependencies/action.yml in PR workflow, and done using direct rust toolchain commands in Release workflows
  • PR workflows run on ubuntu-latest, which translates to ubuntu-22.04, but release workflows run with ubuntu-20.04
  • Some configs are passed along during build in GitHub actions workflows, while some config is passed using .cargo/config files

This issue will likely evolve a bit more before we find all the discrepancies and fix them.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.