spinframework / spinframework/spin
Releases: update test components Cargo.lock?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 6.5k
- Forks
- 310
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 24
Description
See https://github.com/fermyon/spin/pull/2260#issuecomment-1917860833
When bumping the Spin version for a release (seen recently in https://github.com/fermyon/spin/pull/2260), the Lint check failed with:
...
M tests/test-components/components/Cargo.lock
Git working tree dirtied by lints. Run 'make update-cargo-locks' and check in changes
The release docs inform to run make update-cargo-locks, but this target currently only appears to update the top-level Cargo.lock and those under examples... Do we need to add tests as well?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the update-cargo-locks target in Makefile and compare the lockfiles it updates with tests/test-components/components/Cargo.lock. Read docs/content/release-process.md and the referenced release pull request context, then run the lint check after testing the target. Done means the release workflow no longer dirties the working tree because of the test component lockfile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, release, testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100