spinframework / spinframework/spin
Fix trigger config validation
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 6.5k
- Forks
- 310
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 24
Description
The manifest v2 implementation splits up parsing into steps that are organizationally easier to manage, but which also broke standalone validation of trigger config (without actually invoking spin up). This was left out of Spin 2.0 as it seemed to be "just" an error message quality problem, but I didn't consider that this also impacts spin deploy where if a user doesn't first test a manifest with spin up they may deploy an app that just won't work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #1950 and tracing the manifest v2 parsing flow used by standalone validation, spin up, and spin deploy. Done means invalid trigger configuration is detected before deployment even when spin up has not been run, with the resulting validation behavior checked across those paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, wasm
- Domain
- cli, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100