spinframework / spinframework/spin
flag to fail deployment if apps readiness check timeout without success
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 6.5k
- Forks
- 310
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 24
Description
it seems there is a bug right now on trying to update app on Fermyon Cloud. I am adding a test for it and it also seems like spin cloud deploy would exit with code 0 even if readiness check timeouts.
what do you think about adding a flag to spin cloud deploy, which will make the spin command exit with error code if readiness is not established. it will be useful in CI/CD scenarios as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the spin cloud deploy entry point and the readiness-check test mentioned in the issue. Reproduce a deployment whose readiness check times out, then verify that the proposed flag makes the command exit nonzero while readiness succeeds normally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, wasm
- Domain
- cli, cloud
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100