spinframework / spinframework/spin

CI: Automated templates tag push may not run

Open
#1,302 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug ci
Dominant language
Rust
Stars
6.5k
Forks
310
Avg merge
1d 20h
Merged PRs (30d)
24

Description

Currently we have automation around pushing a template tag (eg spin/templates/v1.0) for each new Spin release.

However, it depends on the automated sdk bump PR be merged specifically via a merge commit. If merged via another approach, say via rebase, the automation won't run, as it relies on data only present on a merge commit event (eg github.event.commits[0].author.name == 'fermybot').

We should improve the robustness of this automation so it will run as intended regardless of how the sdk bump PR is merged into main.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read .github/workflows/release.yml lines 258-318, focusing on the SDK bump PR and automated template-tag steps and their use of merge-commit data. Trace how the workflow behaves for different merge methods; done means the template tag push runs after the SDK bump PR reaches main regardless of how it was merged.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.