spinframework / spinframework/spin
e2e tests docker image is built everytime
Open
Nobody has claimed this yet.
ci
testing
- Dominant language
- Rust
- Stars
- 6.5k
- Forks
- 310
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 24
Description
we can possibly publish docker image in separate action which is triggered only if Dockerfile has changed.
few gotchas to keep in mind:
- on PR workflow, if Dockerfile has changed, build a new one and use that for testing e2e tests. dont push to ghcr
- on merge to main, if Dockerfile has changed in this PR, tag a new version (and a latest version) and push to ghcr
- otherwise use the existing image from ghcr instead of building it all the time
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the existing e2e test workflow, merge-to-main workflow, and Dockerfile to find where the image is built and consumed. Verify the PR path builds without pushing, while merges rebuild and push tagged and latest images only when Dockerfile changes; otherwise e2e tests should use the existing GHCR image.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, github-actions
- Domain
- ci-cd, testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100