spinframework / spinframework/spin

Logging sensitive data

Open
#1,009 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
6.5k
Forks
310
Avg merge
1d 20h
Merged PRs (30d)
24

Description

https://github.com/fermyon/spin/blob/04d67d5fd5882aafe028a2d03c56095d8d364ece/crates/outbound-pg/src/lib.rs#L240

Logs password in the clear-text which probably isn't desired.

Refs:
https://github.com/iqlusioninc/crates/tree/main/secrecy might help controlling such stuff if/where applicable.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in crates/outbound-pg/src/lib.rs around line 240 and inspect how the password reaches the log message. Review the referenced secrecy crate for applicable handling, then verify that the outbound PostgreSQL path no longer emits the password in clear text.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.