spinframework / spinframework/spin-operator
Replace "weird" selector labels with something more conventional
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 289
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
Early in the development of spin-operator I introduced this "weird" approach with service selector labels where the key is dynamic and contains the app ID. AFAIK nothing actually depends on this weird behavior today, so it would probably be good to switch to a more conventional selector. Pods are already generated with both the "weird" labels and a "normal" core.spinkube.dev/app-name: <app-id> label, so the service selector can probably just switch to the latter, followed by removing the former assuming it is unused.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace where the service selector and pod labels are generated in spin-operator, starting with the existing app ID label and the dynamic-key labels described in the issue. Confirm whether the dynamic labels are referenced elsewhere, then verify that services select by core.spinkube.dev/app-name and that unused labels are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100