spinframework / spinframework/spin-operator
How to change default listening port for SpinApp?
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 289
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
It seems to me that the SPIN_HTTP_LISTEN_ADDR is hard-coded in the deployment.go (i.e. https://github.com/spinkube/spin-operator/blob/main/internal/controller/deployment.go#L121-L124). Suggest: maybe we should add port to SpinAppSpec to control what listening port the app is listening on?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with internal/controller/deployment.go at lines 121-124 and trace how SpinAppSpec is used when the deployment is built. Determine how a configurable port should flow from the SpinApp resource into the generated deployment, then verify that the resulting listening address uses the requested port.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes, wasm
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100