spinframework / spinframework/spin-operator

Rethink `SpinAppExecutor` deployment config options

Open
#269 3 comments 0 reactions 1 assignee View on GitHub

@endocrimes is already working on this.

Since Jul 19, 2024.

api-next enhancement needs discussion
Dominant language
Go
Stars
289
Forks
34
PR merge metrics
No merged PRs in 30d

Description

The createDeployment field is redundant. We can determine whether the deployment should be created based on whether deploymentConfig is defined or not.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.