spinframework / spinframework/spin-docs

DB SDKs: Connection close()

Open
#195 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6
Forks
23
Avg merge
1d 11h
Merged PRs (30d)
9

Description

Recent versions of the TS/JS, Python and Rust SDKs don't appear to surface a close() method on the db Connection (postgres, sqlite and mysql). (Perhaps not the upcoming Go SDK either? Though the current example snippets do show use.)

Find out if: 1. if Spin is doing this correctly and 2. how to surface it in SDKs.

Originally posted by @itowlson in https://github.com/spinframework/spin-docs/pull/190#discussion_r3075515040

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the current Connection APIs and example snippets for the TypeScript/JavaScript, Python, Rust, and possible Go SDKs, checking the postgres, sqlite, and mysql variants. Review the discussion linked from the original report to establish whether close() is already surfaced correctly. Done means documenting the finding and defining the SDK changes, if any, needed to expose connection closing consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, mysql, postgres, python, rust, sqlite, typescript
Domain
backend-api-design, database, documentation
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.