DefaultX509Source should have the ability to set up more options on WorkloadApiClient
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 46
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Description
Currently we can configure, spiffeSocketPath over io.spiffe.workloadapi.DefaultX509Source.X509SourceOptions.
But there are more configuration options available on io.spiffe.workloadapi.DefaultWorkloadApiClient.ClientOptions which we would like to customize while creating a new X509 source. Is it possible to make ClientOptions be configurable from X509SourceOptions as well?
Also would be great if retryExecutor can also be made customizable?
Sometimes we would like to run these as daemon threads instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with io.spiffe.workloadapi.DefaultX509Source.X509SourceOptions and compare it with io.spiffe.workloadapi.DefaultWorkloadApiClient.ClientOptions, including how retryExecutor is created. Determine the supported configuration and daemon-thread behavior, then verify that creating an X509 source can pass the requested client options and retry executor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100