spiffe / spiffe/java-spiffe

Proposal to remove commons-validator dependency

Open
#466 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
46
Forks
28
PR merge metrics
No merged PRs in 30d

Description

Please review the proposal #464 to remove the commons-validator dependency (and its transitive dependencies). Only one method from the library was used throughout the codebase. The guava-based replacement seems to be simple and already on the classpath. One thing to consider is which flavour of guava should be declared (-android vs -jre)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing proposal #464 and locating the commons-validator dependency declaration and its usages in the codebase. Compare the existing Guava-based replacement and determine whether the android or jre flavour is appropriate. Done means the dependency and transitive dependencies are removed, the replacement works for all usages, and the project tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.