sphinx-doc / sphinx-doc/sphinx
What's up with sphinx/themes/pyramid/static/epub.css?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
It has a header that claims that it's default.css_t:
In reality, this file is very similar to basic.css_t, it has only a few differences:
If both files are actually needed, shouldn't they re-use the common part?
The actual file default.css_t doesn't seem to exist, yet it is mentioned in the code:
There is only a default.css, which is clearly different:
default.css is also mentioned here, which also seems out of place:
It seems to have something to do with the "changes" builder (which I've never heard of before today):
I can't really check what that's all about, because the "changes" builder doesn't seem to work for me (it creates an empty output directory).
Finally, default.css is mentioned in a few places regarding configuration, where it's probably also a bit anachronistic:
What's up with all that?
Am I missing something?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing sphinx/themes/pyramid/static/epub.css_t with sphinx/themes/basic/static/basic.css_t, then trace the default.css_t and default.css references in sphinx/builders/changes.py, sphinx/builders/html/init.py, and the configuration templates. Check how the changes builder and referenced assets are exercised. Done means the stylesheet references and shared CSS are consistent, obsolete names are resolved, and the changes builder still produces its intended output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system, documentation
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100