spf13 / spf13/cast

Inconsistent out of bounds errors

Open
#260 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
4k
Forks
337
Avg merge
15m
Merged PRs (30d)
1

Description

The library currently handles out of bounds errors inconsistently:

  • Strings exceeding int64 and uint64 bounds will return an error (from strconv)
  • Strings exceeding other int/uint types won't return an error (unless it overflows int64/uint64) (no bit size in strconv)
  • Any other number conversions will silently overflow (which is how Go handles casting internally)

At least string parsing should be consistent.

Also see #171

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the string conversion paths and the behavior described for strconv, then read the related discussion in #171. Compare parsing and numeric conversion behavior across the supported int and uint types. The issue does not define the preferred overflow behavior, so completion requires agreeing on what consistent string parsing should mean before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.